Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-field): fix underline at different zoom levels #7567

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 5, 2017

fixes #7494

@mmalerba mmalerba requested a review from crisbeto October 5, 2017 21:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2017
@@ -145,6 +145,8 @@ $mat-form-field-underline-height: 1px !default;
position: absolute;
height: $mat-form-field-underline-height;
width: 100%;
// Prevents underline from disappearing at lower zoom levels.
transform: perspective(1px);
Copy link
Member

@crisbeto crisbeto Oct 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this fixes the issue. The only way I managed to break it on my machine was to zoom out to 33% and these changes don't seem to help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a little weird, they don't all seem to break, I think it has to do with their vertical position or something. I saw some of them broken at 90% on the input demo page, this fixes it for >= 50% which I think is reasonable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it all depends on your OS/Screen size/Browser combo and whether it hits some weird value that doesn't round off correctly. We could get this in and see if people still see the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suspect this will fix it, it does for me

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 6, 2017
@andrewseguin andrewseguin merged commit 5cffd7c into angular:master Oct 9, 2017
@jessicacastro
Copy link

This fix is ​​great but at 33% and 25% zoom the line disappears again

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Bug) .mat-form-field-underline not rendering in Webkit browsers
5 participants