Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): remove inert focus call #7729

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 11, 2017

Removes an attempt to focus the select panel after the animation is done. This doesn't do anything, because the panel isn't focusable, however it'll start throwing in an upcoming Angular release.

cc @matsko

Removes an attempt to focus the select panel after the animation is done. This doesn't do anything, because the panel isn't focusable, however it'll start throwing in an upcoming Angular release.
@crisbeto crisbeto requested a review from kara as a code owner October 11, 2017 21:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogomsouza
Copy link

I updated to angular 5.0 today and now I have this error. When this version will be available to be compatible with angular 5?

@finalxcode
Copy link

finalxcode commented Nov 3, 2017

@diogomsouza i have same problem + 1

@shrralis
Copy link

shrralis commented Nov 3, 2017

@diogomsouza @finalxcode me too

@finalxcode
Copy link

@shrralis hope this issue can be sloved in time.

@RobertPaulson90
Copy link

RobertPaulson90 commented Nov 6, 2017

Can we please get this ASAP. Is there an easy way to hack this into my own 2.0.0-beta.12 Material install?

@rsaulo
Copy link

rsaulo commented Nov 6, 2017

Same problem here, any hack available?

@diogomsouza
Copy link

rsaulo, as I have global error handling configured in my application, I put an "IF" to ignore this error, it's horrible but it was the only way I found it to not have to roll back to 4.x.

@rsaulo
Copy link

rsaulo commented Nov 6, 2017

Hi, i did the same for instance. Thanks!

@hanskishore
Copy link

For the time being, you can update file in node_modules @angular/material/esm5/select.es5.js
at line 742

    MatSelect.prototype._onFadeInDone = function () {
        this._panelDoneAnimating = this.panelOpen;
        if(this.panel){
            this.panel.nativeElement.focus();
        }
        this._changeDetectorRef.markForCheck();
    };

@tamohugues
Copy link

I have same error with Mat-DatePicker to

@diogomsouza
Copy link

thanks hanskishore, this is a much better solution.

@RobertPaulson90
Copy link

RobertPaulson90 commented Nov 7, 2017

Nice fix for development @hanskishore. Works great, but my build server obviously picks up a fresh Material and the bug is there when deployed (to function test, not production lol). Hope we get a fix on npm soon 👍 Until then, RIP Angular 5 and TypeScript 2.5

@PhilippHeuer
Copy link

The new rc for 5 contains the fix:

"@angular/material": "^5.0.0-rc0",
"@angular/cdk": "^5.0.0-rc0",

@finalxcode
Copy link

@PhilippHeuer @crisbeto thanks

@didyk
Copy link

didyk commented Nov 20, 2017

@PhilippHeuer but Angular Universal doesn't work, because 5.0.0-rc0 use Window

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.