-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): remove inert focus call #7729
Conversation
Removes an attempt to focus the select panel after the animation is done. This doesn't do anything, because the panel isn't focusable, however it'll start throwing in an upcoming Angular release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I updated to angular 5.0 today and now I have this error. When this version will be available to be compatible with angular 5? |
@diogomsouza i have same problem + 1 |
@diogomsouza @finalxcode me too |
@shrralis hope this issue can be sloved in time. |
Can we please get this ASAP. Is there an easy way to hack this into my own 2.0.0-beta.12 Material install? |
Same problem here, any hack available? |
rsaulo, as I have global error handling configured in my application, I put an "IF" to ignore this error, it's horrible but it was the only way I found it to not have to roll back to 4.x. |
Hi, i did the same for instance. Thanks! |
For the time being, you can update file in node_modules @angular/material/esm5/select.es5.js MatSelect.prototype._onFadeInDone = function () {
this._panelDoneAnimating = this.panelOpen;
if(this.panel){
this.panel.nativeElement.focus();
}
this._changeDetectorRef.markForCheck();
}; |
I have same error with Mat-DatePicker to |
thanks hanskishore, this is a much better solution. |
Nice fix for development @hanskishore. Works great, but my build server obviously picks up a fresh Material and the bug is there when deployed (to function test, not production lol). Hope we get a fix on npm soon 👍 Until then, RIP Angular 5 and TypeScript 2.5 |
The new rc for 5 contains the fix:
|
@PhilippHeuer @crisbeto thanks |
@PhilippHeuer but Angular Universal doesn't work, because 5.0.0-rc0 use Window |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes an attempt to focus the select panel after the animation is done. This doesn't do anything, because the panel isn't focusable, however it'll start throwing in an upcoming Angular release.
cc @matsko