fix(select,input): inconsistent disabled text color #7794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
7793/disabled-input-text
branch
from
40a9101
to
ba7be78
Compare
mmalerba
approved these changes
Oct 14, 2017
mmalerba
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
7793/disabled-input-text
branch
2 times, most recently
from
fffb647
to
eda9125
Compare
|
@crisbeto please rebase. Thanks! |
Fixes the select and input having different disabled text colors and not taking colors from the palettes. Fixes angular#7793.
crisbeto
force-pushed
the
7793/disabled-input-text
branch
from
eda9125
to
1165d67
Compare
|
Rebased @tinayuangao. |
mmalerba
pushed a commit
that referenced
this pull request
Dec 8, 2017
Fixes the select and input having different disabled text colors and not taking colors from the palettes. Fixes #7793.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the select and input having different disabled text colors and not taking colors from the palettes.
Fixes #7793.
Note: The disabled text color is currently wrong (It's supposed to be 0.5, but it's actually 0.3). It will be fixed by #7421.
Another note: Some screenshot test failures are to be expected because of the slightly different shades of grey.