Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): prevent slider thumb from getting cropped #8061

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

alexshevch
Copy link
Contributor

Slider thumb may sometimes get cropped by a scale transformation.
Removing backface visibility ensures that the thumb is painted correctly.

Slider thumb may sometimes get cropped by a scale transformation.
Removing backface visibility ensures that the thumb is painted correctly.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 26, 2017
@alexshevch
Copy link
Contributor Author

I signed it.

@mmalerba
Copy link
Contributor

mmalerba commented Dec 6, 2017

are you sure you used the same account to sign it as you did to create the commits? it should automatically update if its signed properly

@alexshevch
Copy link
Contributor Author

Thank you for pointing it out, @mmalerba. Google pulled up a different email when I was signing a CLA. I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Dec 6, 2017
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 6, 2017
@mmalerba
Copy link
Contributor

mmalerba commented Dec 6, 2017

great, thanks!

@andrewseguin andrewseguin merged commit 0b05a1f into angular:master Dec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
Slider thumb may sometimes get cropped by a scale transformation.
Removing backface visibility ensures that the thumb is painted correctly.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants