Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): remove IE clear icon #8095

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

crisbeto
Copy link
Member

Removes IE's native clear icon from inputs, because it makes them inconsistent between browsers.

Fixes #8076.

Removes IE's native clear icon from inputs, because it makes them inconsistent between browsers.

Fixes angular#8076.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 28, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 28, 2017
@alexfung888
Copy link

alexfung888 commented Oct 29, 2017

@crisbeto shouldn't you add the feature to all browsers, instead of removing it from IE?

Actually I need to write a custom component to add a clear button to the datepicker.

@andrewseguin andrewseguin merged commit 2fa679b into angular:master Nov 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker has clear value button in IE but not in Chrome/Firefox
5 participants