Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(types): null chk descriptions, type placement updates #8125

Merged
merged 1 commit into from
Oct 30, 2017
Merged

docs(types): null chk descriptions, type placement updates #8125

merged 1 commit into from
Oct 30, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 30, 2017

New PR for #7713

@amcdnl amcdnl self-assigned this Oct 30, 2017
@amcdnl amcdnl requested a review from jelbourn October 30, 2017 14:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017
@amcdnl amcdnl mentioned this pull request Oct 30, 2017
Merged
jelbourn
jelbourn approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 30, 2017
@mmalerba mmalerba merged commit e703b3e into angular:master Oct 30, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@amcdnl amcdnl

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amcdnl @jelbourn @googlebot @mmalerba