Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): unable to reopen when closed by detaching overlay #8232

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 4, 2017

Fixes not being able to reopen a tooltip that was closed via OverlayRef.detach (e.g. by the CloseScrollStrategy).

Fixes not being able to reopen a tooltip that was closed via `OverlayRef.detach` (e.g. by the `CloseScrollStrategy`).
@crisbeto crisbeto added the in progress This issue is currently in progress label Nov 4, 2017
@crisbeto crisbeto self-assigned this Nov 4, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2017
@crisbeto crisbeto assigned andrewseguin and unassigned crisbeto Nov 4, 2017
@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Nov 4, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 8, 2017
@josephperrott josephperrott merged commit 0719c38 into angular:master Nov 10, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants