-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix travis required tests not running #8437
build: fix travis required tests not running #8437
Conversation
* Fixes that the `travis_required` CI mode isn't running. This mode is important for Firefox and Chrome testing.
5315baa
to
7b87e06
Compare
@jelbourn Fixed the test failure in Firefox 57. Everything is green now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, add merge-ready when ready
src/lib/input/input.spec.ts
Outdated
@@ -123,7 +123,7 @@ describe('MatInput without forms', function () { | |||
// Firefox, Safari Desktop and IE don't support type="date" and fallback to type="text". | |||
it('should be treated as empty if type is date on Firefox and IE', | |||
inject([Platform], (platform: Platform) => { | |||
if (platform.TRIDENT || platform.FIREFOX || (platform.SAFARI && !platform.IOS)) { | |||
if (platform.TRIDENT || (platform.SAFARI && !platform.IOS)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the comment above?
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
travis_required
CI mode isn't running. This mode is important for Firefox and Chrome testing.