fix(input): align caret color with spec #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Nov 28, 2017
mmalerba
added
pr: lgtm
action: merge
Based on the text field spec (https://material.io/guidelines/components/text-fields.html), the input caret color should match the underline color.
crisbeto
force-pushed
the
input-caret-color
branch
from
d38a120
to
6d43654
Compare
crisbeto
added
target: minor
andrewseguin
added
the
presubmit failures
|
Looks like caret-color is not a supported CSS property internally. Probably since it is not supported across browsers. @jelbourn Have you run into this before with other CSS properties? |
|
Did some investigation w/ Andrew: we're going to try to update the internal css compiler to be aware of this property |
|
Andrew sent a fix for the missing property, scheduled another presubmit now |
jelbourn
removed
the
presubmit failures
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
Based on the text field spec (https://material.io/guidelines/components/text-fields.html), the input caret color should match the underline color.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
Based on the text field spec (https://material.io/guidelines/components/text-fields.html), the input caret color should match the underline color.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
Based on the text field spec (https://material.io/guidelines/components/text-fields.html), the input caret color should match the underline color.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Based on the text field spec (https://material.io/guidelines/components/text-fields.html), the input caret color should match the underline color.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the text field spec (https://material.io/guidelines/components/text-fields.html), the input caret color should match the underline color.