perf(ripple): use passive event listeners #8719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Nov 29, 2017
| @@ -170,25 +169,27 @@ export class RippleRenderer { | |||
|
|
|||
| /** Sets the trigger element and registers the mouse events. */ | |||
| setTriggerElement(element: HTMLElement | null) { | |||
| const eventOptions = supportsPassiveEventListeners() ? ({passive: true} as any) : false; | |||
There was a problem hiding this comment.
Wouldn't it be enough to check that at RippleRender instantiation (e.g. constructor, or property) ?
There was a problem hiding this comment.
I suppose so, but the check isn't particularly expensive since we cache the result.
There was a problem hiding this comment.
I'd prefer having it as a property since it's not necessary to have this in the setTriggerElement method.
crisbeto
force-pushed
the
ripple-passive-listener
branch
from
988223e
to
e8a8c7b
Compare
Switches all of the ripple-related event listeners to be passive for improved performance and to prevent Chrome from logging warnings for almost every Material component.
crisbeto
force-pushed
the
ripple-passive-listener
branch
from
e8a8c7b
to
1a70edf
Compare
crisbeto
added
target: minor
|
Why this wasn't merged for the 5.0.1 update? Will it get merged for the next patch? |
andrewseguin
pushed a commit
that referenced
this pull request
Dec 19, 2017
Switches all of the ripple-related event listeners to be passive for improved performance and to prevent Chrome from logging warnings for almost every Material component.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches all of the ripple-related event listeners to be passive for improved performance and to prevent Chrome from logging warnings for almost every Material component. Also converts a few methods to arrow functions so we don't have to
bindthem explicitly.