-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(layout): handle platforms that don't support matchMedia #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an extra check to ensure that the current platform supports `window.matchMedia`. Fixes angular#8710.
googlebot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
Dec 2, 2017
josephperrott
approved these changes
Dec 5, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
josephperrott
added
pr: lgtm
action: merge
The PR is ready for merge by the caretaker
target: major
This PR is targeted for the next major release
target: patch
This PR is targeted for the next patch release
and removed
pr: needs review
target: major
This PR is targeted for the next major release
labels
Dec 5, 2017
andrewseguin
added
the
presubmit failures
This PR has failures in Google's internal presubmit process and cannot be immediately merged
label
Dec 13, 2017
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 8, 2018
…8775) Adds an extra check to ensure that the current platform supports `window.matchMedia`. Fixes angular#8710.
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Jan 9, 2018
…8775) Adds an extra check to ensure that the current platform supports `window.matchMedia`. Fixes angular#8710.
jelbourn
pushed a commit
that referenced
this pull request
Jan 9, 2018
Adds an extra check to ensure that the current platform supports `window.matchMedia`. Fixes #8710.
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Adds an extra check to ensure that the current platform supports `window.matchMedia`. Fixes #8710.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
presubmit failures
This PR has failures in Google's internal presubmit process and cannot be immediately merged
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra check to ensure that the current platform supports
window.matchMedia
.Fixes #8710.