fix(dialog): change order of button actions #9021
Conversation
donroyco
requested review from
amcdnl,
jelbourn and
tinayuangao
as code owners
googlebot
added
the
cla: yes
| <button mat-button (click)="onNoClick()" tabindex="-1">No Thanks</button> | ||
| <button mat-button [mat-dialog-close]="data.animal" tabindex="2">Ok</button> |
There was a problem hiding this comment.
Not something that you added, but while we're at it, can you remove the tabindex from the buttons here and in the other example and replace the positive tabindex with an cdk-focus-initial attribute?
There was a problem hiding this comment.
Will do @crisbeto, is there an attribute order? <button mat-button cdk-focus-initial [mat-dialog-close]="true"> or <button mat-button [mat-dialog-close]="true" cdk-focus-initial>?
There was a problem hiding this comment.
We don't have any rules for the attribute order.
| <button mat-raised-button mat-dialog-close>Close</button> | ||
| <button mat-raised-button color="primary" mat-dialog-close>Submit</button> |
There was a problem hiding this comment.
Can you add the attribute to this one as well? Also sorry, but I just remembered that we deprecated cdk-focus-initial. cdkFocusInitial is the proper one.
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Change order of buttons for affirmative actions, according to Material guidelines. This fixes #9019