feat(dialog): allow for closing on navigation to be disabled #9024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Dec 18, 2017
| @@ -42,9 +44,13 @@ export class MatDialogRef<T, R = any> { | |||
| /** Result to be passed to afterClosed. */ | |||
| private _result: R | undefined; | |||
|
|
|||
| /** Subscription to changes in the user's location. */ | |||
| private _locationChanges: ISubscription = Subscription.EMPTY; | |||
There was a problem hiding this comment.
Why is this ISubscription instead of Subscription?
There was a problem hiding this comment.
It's because the Angular Location isn't actually an observable and it doesn't return a regular Subscription.
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
8983/dialog-disable-navigation-close
branch
from
c683407
to
d917bb4
Compare
|
@crisbeto this passes presubmit, I can merge once you're able to rebase |
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history. Fixes angular#8983.
crisbeto
force-pushed
the
8983/dialog-disable-navigation-close
branch
from
d917bb4
to
4e08418
Compare
|
Rebased. |
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history. Fixes #8983.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history.
Fixes #8983.