Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove tabindex from input #9111

Merged
merged 1 commit into from
Jan 3, 2018
Merged

docs: remove tabindex from input #9111

merged 1 commit into from
Jan 3, 2018

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Dec 24, 2017

see #9107

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 24, 2017
@crisbeto
Copy link
Member

Can you switch the title to docs instead of fix?

@Hirse Hirse changed the title fix: remove tabindex from input docs: remove tabindex from input Dec 25, 2017
@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 1, 2018
@crisbeto crisbeto mentioned this pull request Jan 3, 2018
Closed
@Hirse
Copy link
Contributor Author

Hirse commented Jan 3, 2018

Is there anything for me to do to get this merged?

@crisbeto
Copy link
Member

crisbeto commented Jan 3, 2018

Nope, it's marked as ready to be merged whenever the caretaker gets to it.

jelbourn
jelbourn approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit e20d8f0 into angular:master Jan 3, 2018
@Hirse Hirse deleted the patch-1 branch January 3, 2018 23:27
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
@Hirse @jelbourn
docs(input): remove tabindex from example (angular#9111)
b5b39eb
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
@Hirse @jelbourn
docs(input): remove tabindex from example (angular#9111)
3dcecaf
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
@Hirse @jelbourn
docs(input): remove tabindex from example (#9111)
490b3b4
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hirse @crisbeto @jelbourn @googlebot