Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): fixes blurry overlay #943

Closed
wants to merge 1 commit into from
Closed

fix(overlay): fixes blurry overlay #943

wants to merge 1 commit into from

Conversation

robertmesserle
Copy link
Contributor

  • rounds pixel values used in connected-position-strategy
  • replaces percent-based offset with calculated pixel values in
    global-position-strategy

closes #932

R: @jelbourn

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 2, 2016
@@ -15,7 +15,7 @@ $md-tooltip-padding: 8px;
padding: 0 $md-tooltip-padding;
border-radius: 2px;
font-family: $md-font-family;
font-size: 10px;
font-size: 11px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment explaining why we're going off-spec.

@jelbourn
Copy link
Member

jelbourn commented Aug 8, 2016

Need unit tests for this change.

@jelbourn
Copy link
Member

@robertmesserle looks like legit test failures

- rounds pixel values used in `connected-position-strategy`
- replaces percent-based offset with calculated pixel values in
  `global-position-strategy`

closes #932
@robertmesserle
Copy link
Contributor Author

Work still needed:

  • The unit tests will need to be refactored using async rather than fakeAsync due to the addition of requestAnimationFrame
  • E2E tests are failing on Travis only - I have not been able to recreate this error locally in order to debug.
  • We should make the percent conversion a more generic process that supports any values rather than a hard-coded check for -50%.

@philipooo
Copy link

I copied these changes to alpha.9 and noticed that the dialog gets not repositioned to the middle of the screen when the content changes (when open). Thanks for the change btw!

@jelbourn jelbourn added in progress This issue is currently in progress and removed pr: needs review labels Nov 18, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 2, 2016

Replaced by #1962

@jelbourn jelbourn closed this Dec 2, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement in progress This issue is currently in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(overlay): overlays are sometimes blurred in Chrome
4 participants