-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overlay): fixes blurry overlay #943
fix(overlay): fixes blurry overlay #943
Conversation
@@ -15,7 +15,7 @@ $md-tooltip-padding: 8px; | |||
padding: 0 $md-tooltip-padding; | |||
border-radius: 2px; | |||
font-family: $md-font-family; | |||
font-size: 10px; | |||
font-size: 11px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment explaining why we're going off-spec.
Need unit tests for this change. |
@robertmesserle looks like legit test failures |
- rounds pixel values used in `connected-position-strategy` - replaces percent-based offset with calculated pixel values in `global-position-strategy` closes #932
Work still needed:
|
I copied these changes to alpha.9 and noticed that the dialog gets not repositioned to the middle of the screen when the content changes (when open). Thanks for the change btw! |
Replaced by #1962 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
connected-position-strategy
global-position-strategy
closes #932
R: @jelbourn