-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: show deletion target in docs #9648
build: show deletion target in docs #9648
Conversation
* Surfaces the @deletion-target JSDoc information into the Dgeni HTML output. Currently it will add a title to the deprecation marker. Closes angular#9641
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -19,7 +21,9 @@ | |||
</div> | |||
{%- endif -%} | |||
{%- if property.isDeprecated -%} | |||
<div class="docs-api-deprecated-marker">Deprecated</div> | |||
<div class="docs-api-deprecated-marker" {$ macros.deprecationTitle(property) $}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be cool to add a dotted underline to the deprecation marker to indicate that there's a hover effect. We could do this in a follow-up PR on the docs site w/ something like
.docs-api-deprecated-marker[title] {
border-bottom: 1px dotted gray;
}
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular/components#9648
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular/components#9648
* Adds a dotted underline to the `Deprecated` markers. Those can be hovered to see more information about the deprecation / deletion. * Fixes that the deprecation markers are too big and are not looking good in the API table * Adds a line through property names that are also deprecated. This makes it clear that this API is deprecated and also looks pretty good. References angular/components#9648
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #9641