Skip to content

Commit

Permalink
build: update dependency jasmine to v5 (#1453)
Browse files Browse the repository at this point in the history
PR Close #1453
  • Loading branch information
angular-robot authored and josephperrott committed Oct 19, 2023
1 parent b893be2 commit 3c092a0
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 18 deletions.
13 changes: 13 additions & 0 deletions .yarn/patches/@bazel-jasmine-npm.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/jasmine_runner.js b/jasmine_runner.js
index 097eb920..2e6bbcd2 100644
--- a/jasmine_runner.js
+++ b/jasmine_runner.js
@@ -147,7 +147,7 @@ async function main(args) {
// TODO(6.0): remove support for deprecated versions of Jasmine that use the old API &
// remember to update the `peerDependencies` as well.
// Jasmine versions prior to 4.0.0 should use the old API.
- if (jrunner.coreVersion().charAt(0) !== '4') {
+ if (Number(jrunner.coreVersion().charAt(0)) < 4) {
console.warn(`DEPRECATED: Support for Jasmine versions prior to '4.0.x' is deprecated in '@bazel/jasmine'.`);

// Old Jasmine API.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"@angular/router": "17.0.0-rc.0",
"@bazel/bazelisk": "^1.11.0",
"@bazel/ibazel": "^0.23.0",
"@bazel/jasmine": "5.8.1",
"@bazel/jasmine": "patch:@bazel/jasmine@npm:5.8.1#.yarn/patches/@bazel-jasmine-npm.patch",
"@google-cloud/firestore": "^7.0.0",
"@google-cloud/storage": "^7.0.0",
"@octokit/auth-app": "6.0.1",
Expand All @@ -100,7 +100,7 @@
"@types/git-raw-commits": "^2.0.0",
"@types/glob": "^8.0.0",
"@types/inquirer": "9.0.6",
"@types/jasmine": "^4.0.0",
"@types/jasmine": "5.1.1",
"@types/jsdom": "^21.0.0",
"@types/license-checker": "^25.0.3",
"@types/opener": "^1.4.0",
Expand All @@ -126,7 +126,7 @@
"glob": "10.3.10",
"husky": "^8.0.0",
"inquirer": "9.2.11",
"jasmine": "~4.6.0",
"jasmine": "~5.1.0",
"jasmine-core": "~5.1.0",
"jsdom": "^22.0.0",
"jsonc-parser": "^3.2.0",
Expand Down
45 changes: 30 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ __metadata:
"@bazel/concatjs": 5.8.1
"@bazel/esbuild": 5.8.1
"@bazel/ibazel": ^0.23.0
"@bazel/jasmine": 5.8.1
"@bazel/jasmine": "patch:@bazel/jasmine@npm:5.8.1#.yarn/patches/@bazel-jasmine-npm.patch"
"@bazel/protractor": 5.8.1
"@bazel/runfiles": 5.8.1
"@bazel/terser": 5.8.1
Expand Down Expand Up @@ -391,7 +391,7 @@ __metadata:
"@types/git-raw-commits": ^2.0.0
"@types/glob": ^8.0.0
"@types/inquirer": 9.0.6
"@types/jasmine": ^4.0.0
"@types/jasmine": 5.1.1
"@types/jsdom": ^21.0.0
"@types/license-checker": ^25.0.3
"@types/marked": ^5.0.1
Expand Down Expand Up @@ -427,7 +427,7 @@ __metadata:
glob: 10.3.10
husky: ^8.0.0
inquirer: 9.2.11
jasmine: ~4.6.0
jasmine: ~5.1.0
jasmine-core: ~5.1.0
jsdom: ^22.0.0
jsonc-parser: ^3.2.0
Expand Down Expand Up @@ -2480,6 +2480,21 @@ __metadata:
languageName: node
linkType: hard

"@bazel/jasmine@patch:@bazel/jasmine@npm:5.8.1#.yarn/patches/@bazel-jasmine-npm.patch::locator=%40angular%2Fbuild-tooling%40workspace%3A.":
version: 5.8.1
resolution: "@bazel/jasmine@patch:@bazel/jasmine@npm%3A5.8.1#.yarn/patches/@bazel-jasmine-npm.patch::version=5.8.1&hash=fa387d&locator=%40angular%2Fbuild-tooling%40workspace%3A."
dependencies:
c8: ~7.5.0
jasmine-reporters: ~2.5.0
peerDependencies:
jasmine: ">=2.99.0"
jasmine-core: ">=2.99.0"
bin:
bazel-jasmine-runner: jasmine_runner.js
checksum: 830d2dd889fb305623c98b496778dfdb4faac77c015b19a27dace560d829582904834c4dc7f3e5fc3a8ff8468d7c47e89a3156c1f5d633d69a9324472ee8dd86
languageName: node
linkType: hard

"@bazel/protractor@npm:5.8.1":
version: 5.8.1
resolution: "@bazel/protractor@npm:5.8.1"
Expand Down Expand Up @@ -5940,10 +5955,10 @@ __metadata:
languageName: node
linkType: hard

"@types/jasmine@npm:^4.0.0":
version: 4.3.6
resolution: "@types/jasmine@npm:4.3.6"
checksum: 1dd9cc3633db98a0fc7149184cc3916c5158cfdfd65d437b81502d55e5e147305aac3bbce65ed144253b2406e47821629a18d1111b102fdc4f0c6867735a2c91
"@types/jasmine@npm:5.1.1":
version: 5.1.1
resolution: "@types/jasmine@npm:5.1.1"
checksum: 76f0de21314db192e165cbb56229ca74d685ff6c8d233af21723a7bf8848b9e50b70bc321929194a7cda713c48b794e53a80363e02b54e1375dcd4ac1186c7f9
languageName: node
linkType: hard

Expand Down Expand Up @@ -10731,7 +10746,7 @@ __metadata:
languageName: node
linkType: hard

"glob@npm:^7.0.0, glob@npm:^7.0.3, glob@npm:^7.0.6, glob@npm:^7.1.1, glob@npm:^7.1.2, glob@npm:^7.1.3, glob@npm:^7.1.4, glob@npm:^7.1.6, glob@npm:^7.1.7":
"glob@npm:^7.0.0, glob@npm:^7.0.3, glob@npm:^7.0.6, glob@npm:^7.1.1, glob@npm:^7.1.2, glob@npm:^7.1.3, glob@npm:^7.1.4, glob@npm:^7.1.7":
version: 7.2.3
resolution: "glob@npm:7.2.3"
dependencies:
Expand Down Expand Up @@ -12173,7 +12188,7 @@ __metadata:
languageName: node
linkType: hard

"jasmine-core@npm:^4.1.0, jasmine-core@npm:^4.6.0":
"jasmine-core@npm:^4.1.0":
version: 4.6.0
resolution: "jasmine-core@npm:4.6.0"
checksum: c5c5ce16c512cf0bc8b6b4f2d4f0ac7b23cae90624e0cd9d22da3baab3266e9a4da5a9363fb7937b16e0a4cf550bb79183cd74483ce55cfff4b6678434d599b7
Expand Down Expand Up @@ -12217,15 +12232,15 @@ __metadata:
languageName: node
linkType: hard

"jasmine@npm:~4.6.0":
version: 4.6.0
resolution: "jasmine@npm:4.6.0"
"jasmine@npm:~5.1.0":
version: 5.1.0
resolution: "jasmine@npm:5.1.0"
dependencies:
glob: ^7.1.6
jasmine-core: ^4.6.0
glob: ^10.2.2
jasmine-core: ~5.1.0
bin:
jasmine: bin/jasmine.js
checksum: 1034466aac682b212259cd47f681ca70de02e56bf05c2ed51d3a31f3b4da2a797b281e015fed7d0c218aa849e7496ae7595022c48756ca96952c512b813ae465
checksum: 68ca655f05d66fb80d541d2d3305a9a683b76efc21adc5b99a748938881d16dccc3bfe3d091fff802e8c85a9bfce7f825c8ab28ee1656faf268b2ed8cb3b7c4c
languageName: node
linkType: hard

Expand Down

0 comments on commit 3c092a0

Please sign in to comment.