-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: update dependency jasmine to v5 (#1453)
PR Close #1453
- Loading branch information
1 parent
b893be2
commit 3c092a0
Showing
3 changed files
with
46 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/jasmine_runner.js b/jasmine_runner.js | ||
index 097eb920..2e6bbcd2 100644 | ||
--- a/jasmine_runner.js | ||
+++ b/jasmine_runner.js | ||
@@ -147,7 +147,7 @@ async function main(args) { | ||
// TODO(6.0): remove support for deprecated versions of Jasmine that use the old API & | ||
// remember to update the `peerDependencies` as well. | ||
// Jasmine versions prior to 4.0.0 should use the old API. | ||
- if (jrunner.coreVersion().charAt(0) !== '4') { | ||
+ if (Number(jrunner.coreVersion().charAt(0)) < 4) { | ||
console.warn(`DEPRECATED: Support for Jasmine versions prior to '4.0.x' is deprecated in '@bazel/jasmine'.`); | ||
|
||
// Old Jasmine API. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters