Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps): create the code of conduct frontend application #1112

Closed
wants to merge 3 commits into from
Closed

feat(apps): create the code of conduct frontend application #1112

wants to merge 3 commits into from

Conversation

josephperrott
Copy link
Member

Create the initial code of conduct frontend

@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 21, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 21, 2023
@josephperrott
feat(apps): create the code of conduct frontend application
1d3655e 
Create the initial code of conduct frontend
devversion
devversion reviewed Apr 24, 2023
View reviewed changes
apps/BUILD.bazel Show resolved Hide resolved
apps/code-of-conduct/app/BUILD.bazel Outdated Show resolved Hide resolved
apps/code-of-conduct/app/block-user/block-user.component.html Outdated Show resolved Hide resolved
apps/code-of-conduct/app/block-user/block-user.component.html Outdated Show resolved Hide resolved
apps/code-of-conduct/app/block-user/block-user.component.scss Show resolved Hide resolved
apps/code-of-conduct/styles.scss Outdated Show resolved Hide resolved
apps/firebase.json Outdated Show resolved Hide resolved
apps/firebase.json Show resolved Hide resolved
apps/shared/account/account.service.ts Outdated Show resolved Hide resolved
apps/shared/account/account.service.ts Show resolved Hide resolved
devversion
devversion approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- aside from the unresolved comments

apps/code-of-conduct/app/block-user/block-user.component.html Outdated Show resolved Hide resolved
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 28, 2023
@josephperrott
Copy link
Member Author

I am going to merge as is as I will need to do some refactoring to make it testable do to how injection/access works for @angular/fire

@angular-robot
Copy link
Contributor

angular-robot bot commented Apr 28, 2023

This PR was merged into the repository by commit bbf452b.

@angular-robot angular-robot bot closed this in bbf452b Apr 28, 2023
@josephperrott josephperrott deleted the code-of-conduct branch April 28, 2023 20:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephperrott @devversion