fix: escape unsafe patterns in elements, comment nodes and processing instructions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
force-pushed
the
escape_raw_content
branch
2 times, most recently
from
113c586 to
ad21ca6
Compare
alan-agius4
reviewed
Sep 28, 2023
alan-agius4
reviewed
Sep 28, 2023
AndrewKushnir
force-pushed
the
escape_raw_content
branch
2 times, most recently
from
c3bcd83 to
1c8f504
Compare
AndrewKushnir
force-pushed
the
escape_raw_content
branch
2 times, most recently
from
17d7f15 to
e4e1c95
Compare
AndrewKushnir
changed the title
securityMB
reviewed
Oct 1, 2023
AndrewKushnir
force-pushed
the
escape_raw_content
branch
2 times, most recently
from
aa16603 to
9bf2b98
Compare
securityMB
approved these changes
Oct 1, 2023
AndrewKushnir
force-pushed
the
escape_raw_content
branch
from
ff6f266 to
8f25adc
Compare
|
@securityMB thanks for the review 👍 FYI I've used your recommendation and also added tests for escaping util functions (in ab8ff69), so it's easier to extend the coverage if needed. |
AndrewKushnir
force-pushed
the
escape_raw_content
branch
from
8f25adc to
ab8ff69
Compare
alan-agius4
approved these changes
Oct 2, 2023
… instructions This commit updates the logic to espace unsafe patterns: - for elements that can have raw text: all matching closing tags are escaped - for comment nodes: all closing comment tags are escaped - for processing instructions: all `>` symbols are excaped
AndrewKushnir
force-pushed
the
escape_raw_content
branch
from
ab8ff69 to
4f8a2dd
Compare
|
@alan-agius4 thanks for reviewing, I've applied the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the logic to espace unsafe patterns:
>symbols are escaped