Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auto-prefixer): resolve perf impacts as reported by LightHouse #282

Closed
ThomasBurleson opened this issue May 10, 2017 · 3 comments · Fixed by #283
Closed

fix(auto-prefixer): resolve perf impacts as reported by LightHouse #282

ThomasBurleson opened this issue May 10, 2017 · 3 comments · Fixed by #283
Labels
has pr A PR has been created to address this issue performance
Milestone
v2.0.0-beta.9

Comments

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented May 10, 2017 •
edited
Loading

  • Order of flex properties should be improved to use display: flex last.
  • missing standard property display: -webkit-flex;
  • mistakenly using display: -moz-box;

See
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.9 milestone May 10, 2017
@ThomasBurleson ThomasBurleson mentioned this issue May 10, 2017
Merged
@ThomasBurleson ThomasBurleson added the has pr A PR has been created to address this issue label May 11, 2017
@ThomasBurleson ThomasBurleson mentioned this issue May 11, 2017
Merged
ThomasBurleson added a commit that referenced this issue May 20, 2017
@ThomasBurleson
fix(auto-prefixer): resolve perf impacts as reported by LightHouse
1a0cf6a 
* Updated based on output from https://autoprefixer.github.io/
* Removed Mozilla Firefox prefixes as not required for the evergreen browser
* Remove support for IE10 prefixes (`-ms-`); as only IE 11 and Edge are supported
* Remove support for `-webkit-box` required for OLD iOS , Safari 3, BB7
* Fix value transforms for flex-related keys

Fixes #282
ThomasBurleson added a commit that referenced this issue May 20, 2017
@ThomasBurleson
fix(auto-prefixer): resolve perf impacts as reported by LightHouse
5615983 
* Updated based on output from https://autoprefixer.github.io/
* Removed Mozilla Firefox prefixes as not required for the evergreen browser
* Remove support for IE10 prefixes (`-ms-`); as only IE 11 and Edge are supported
* Remove support for `-webkit-box` required for OLD iOS , Safari 3, BB7
* Fix value transforms for flex-related keys

Fixes #282
ThomasBurleson added a commit that referenced this issue May 20, 2017
@ThomasBurleson
fix(auto-prefixer): resolve perf impacts as reported by LightHouse
c5abc35 
* Updated based on output from https://autoprefixer.github.io/
* Removed Mozilla Firefox prefixes as not required for the evergreen browser
* Remove support for IE10 prefixes (`-ms-`); as only IE 11 and Edge are supported
* Remove support for `-webkit-box` required for OLD iOS , Safari 3, BB7
* Fix value transforms for flex-related keys

Fixes #282
ThomasBurleson added a commit that referenced this issue May 24, 2017
@ThomasBurleson
fix(auto-prefixer): resolve perf impacts as reported by LightHouse
49cf7dc 
* Updated based on output from https://autoprefixer.github.io/
* Removed Mozilla Firefox prefixes as not required for the evergreen browser
* Remove support for IE10 prefixes (`-ms-`); as only IE 11 and Edge are supported
* Remove support for `-webkit-box` required for OLD iOS , Safari 3, BB7
* Fix value transforms for flex-related keys

Fixes #282
tinayuangao pushed a commit that referenced this issue May 25, 2017
@ThomasBurleson @tinayuangao
fix(auto-prefixer): resolve perf impacts as reported by LightHouse (#283
bc0c900 
)

* Updated based on output from https://autoprefixer.github.io/
* Removed Mozilla Firefox prefixes as not required for the evergreen browser
* Remove support for IE10 prefixes (`-ms-`); as only IE 11 and Edge are supported
* Remove support for `-webkit-box` required for OLD iOS , Safari 3, BB7
* Fix value transforms for flex-related keys

Fixes #282
@ethanroday
Copy link

ethanroday commented Jun 5, 2017 •
edited
Loading

@ThomasBurleson, removal of --webkit-box in #283 means that flex layouts will no longer work in UC Browser, which has ~10% share WW.
Was there a functional reason for this change, or was it just to cut down on CSS?

@jelbourn
Copy link
Member

jelbourn commented Jun 6, 2017

We aim to mostly support "modern" browsers- ultimately we have to draw the line somewhere. In this case we decided that supporting the final flex spec is necessary to be considered "modern".

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has pr A PR has been created to address this issue performance
Projects
None yet
Milestone
v2.0.0-beta.9
Development

Successfully merging a pull request may close this issue.

fix(auto-prefixer): resolve perf impacts as reported by LightHouse angular/flex-layout
3 participants
@ThomasBurleson @jelbourn @ethanroday