Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

npm WARN @angular/flex-layout@2.0.0-rc.1 requires a peer of @angular/common@^2.2.3 but none was installed #344

Closed
alexjlockwood opened this issue Jul 19, 2017 · 14 comments
Closed

npm WARN @angular/flex-layout@2.0.0-rc.1 requires a peer of @angular/common@^2.2.3 but none was installed #344

alexjlockwood opened this issue Jul 19, 2017 · 14 comments

Comments

@alexjlockwood
Copy link

When I try to install the library I get the following warnings:

npm WARN @angular/flex-layout@2.0.0-rc.1 requires a peer of @angular/common@^2.2.3 but none was installed.
npm WARN @angular/flex-layout@2.0.0-rc.1 requires a peer of @angular/core@^2.2.3 but none was installed.
npm WARN @angular/flex-layout@2.0.0-rc.1 requires a peer of zone.js@^0.7.2 but none was installed.
@jotatoledo
Copy link

jotatoledo commented Jul 19, 2017 •
edited
Loading

The rc.1 version was renamed, into beta.6 (https://github.com/angular/flex-layout/blob/v2.0.0-beta.6/package.json). If you want to use angular 4 (what I assume you are trying to do), then you need to use beta.8 of flex layout

@ThomasBurleson
Copy link
Contributor

Please clean-install @angular/flex-layout v2.0.0-beta.8.

@gimox
Copy link

gimox commented Sep 15, 2017

+1 very bad! clean it from npm

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Sep 15, 2017 •
edited
Loading

@gimox - the Rc.1 was deprecated and we attempted to clean [unpublish] it from the registry.

  • How are you installing the Rc.1 version?
  • How do you propose we improve the cleaning of that invalid release from the npm registry?

We also reported this as an issue on the support@npmjs.com

@gimox
Copy link

gimox commented Sep 15, 2017 •
edited
Loading

hi @ThomasBurleson

How are you installing the Rc.1 version?

  • new project with angular cli
  • npm install @angular/flex-layout --save
  • npm update (now it add rc-1)

(so now i know the problem and i fix the package to not update to major version, but many people don't know that)

How do you propose we improve the cleaning of that invalid release from the npm registry?

bump to a upper version rc-2
or
unpublish it https://docs.npmjs.com/cli/unpublish

@nicksloan
Copy link

If the code is not ready to be in RC, then you need to just acknowledge that the 2.0.0 release is ruined and scrap it. The best thing to do would be to release 2.0.1-beta1 or whatever the first release of the next version number would be. You should never go down again, and unpublishing seems like a bad idea.

@gimox
Copy link

gimox commented Oct 4, 2017

rc1 is the same as beta6, it's a publish error, it can safe unpublish

@nicksloan
Copy link

nicksloan commented Oct 4, 2017 •
edited
Loading

@gimox Except for the fact that some people will certainly have rc1 in their package.json files, so you'll be breaking their code on unpublish.

EDIT: I just realized that you're not the one responsible for the project, as best I can tell.

@ThomasBurleson See above. I strongly discourage removing it from NPM. Version numbers are append only. If you remove a problematic version, you are certain to create even more problems for your users.

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Oct 6, 2017 via email

@un33k
Copy link

un33k commented Oct 6, 2017 •
edited
Loading

Pin down your desired beta version by removing the "^" prefix.

Example:
@angular/flex-layout": "^2.0.0-beta.9" --> @angular/flex-layout": "2.0.0-beta.9"

Otherwise, you will end up with the RC.1 version which is really really old.

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Oct 6, 2017 via email

@nicksloan
Copy link

@ThomasBurleson The concern is not new users, but all of your existing users who you are forcing to come here to figure out how to fix the problem that you created by breaking the semver contract. Many of them have already upgraded to rc.1 erroneously, and the problem won't realistically be fixed until you release rc.2 or, as I have suggested, release 2.0.1-beta.1, which is the only correct course of action.

This is a very disappointing way to manage this project.

@un33k
Copy link

un33k commented Oct 10, 2017

@nicksloan This is still a beta project for a reason. It is not ready yet & mistakes can happen. I am glad that you stumbled on this thread and figured out your way.

@ThomasBurleson I for sure appreciate all the time you put in this project and looking forward to seeing the RC.2 release.

Base on this (+ve) note, let's conclude this thread. Pls.

@ThomasBurleson
Copy link
Contributor

The currently nightly release is stable with Angular 5 and will be an important release for the community. Unfortunately, my team does not control the final testing and actual release processes for this library.

Due to the last 2-3 weeks of intense efforts on Angular Material, Flex-Layout release is pending. We hope to see the next release next week.

I do acknowledge that we need to remove the Beta.1 tag OR publish the next release as 2.0.1-beta.1.
And please note that my team wants @angular/Flex-layout to be a wonderful, versatile Layout tool for angular developers.

We have some amazing additions coming in Q1, 2018.

@angular angular locked and limited conversation to collaborators Oct 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ThomasBurleson @un33k @nicksloan @alexjlockwood @gimox @jotatoledo