This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
fix(FlexLayoutModule): remove console.warn() calls that conflict with ngc+aot #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
pr: lgtm
ThomasBurleson
force-pushed
the
fix/ngc-aot-forRoot
branch
2 times, most recently
from
8a67465 to
aed9238
Compare
* ‘forRoot()' fn is never evaluated in AoT, ngc only analyzes the content of the fn to get the module and ngc does not know what to do with the first statetement (console.warn) * clarify changes to FlexLayoutModule.forRoot() * updates dependency to minimum of Angular v2.3.1. Refs http://github.com/angular/angular#14410 Fixes #174, Fixes #175, Fixes #176, Fixes #178.
ThomasBurleson
force-pushed
the
fix/ngc-aot-forRoot
branch
from
aed9238 to
770cad6
Compare
karlhaas
pushed a commit
to karlhaas/flex-layout
that referenced
this pull request
May 3, 2017
…ngular#179) * ‘forRoot()' fn is never evaluated in AoT, ngc only analyzes the content of the fn to get the module and ngc does not know what to do with the first statetement (console.warn) * clarify changes to FlexLayoutModule.forRoot() * updates dependency to minimum of Angular v2.3.1. Refs http://github.com/angular/angular#14410 Fixes angular#174, Fixes angular#175, Fixes angular#176, Fixes angular#178.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs http://github.com/angular/angular#14410
Fixes #174, Fixes #175, Fixes #176, Fixes #178.