Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api, class): fix valid ngClass usages #431

Merged
merged 2 commits into from
Sep 27, 2017

Conversation

ThomasBurleson
Copy link
Contributor

@ThomasBurleson ThomasBurleson commented Sep 27, 2017

ClassDirective should work properly with class and ngClass usages; and only
instantiate when responsive APIs are used.

  • Similarly StyleDirective not instantiated with ngStyle; only with responsive api usages.

Fixes #428.

ClassDirective should work properly with `class` and `ngClass` usages; and only
instantiate when responsive APIs are used.

* Add test that use @angular/material MdButtonModule md-raised-button
* Update to use latest @angular/material Beta.11

Fixes #428.
* temporarily disable Closure build testing; due to Material Beta.11 package restructures
@ThomasBurleson ThomasBurleson merged commit 0da1f88 into master Sep 27, 2017
@ThomasBurleson ThomasBurleson deleted the thomas/fix-issue-428 branch October 21, 2017 12:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngClass behavior change after latest nightly
2 participants