This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
[WIP] ssr style fix #556
Closed
[WIP] ssr style fix #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove private API references to getDom() * Add PLATFORM_ID to all components
CaerusKaru
force-pushed
the
universal
branch
2 times, most recently
from
f50c5dc to
edec14d
Compare
CaerusKaru
added
the
discussion
|
Also blocked by #296 since this relies on having correct default styles. Edit: discussed offline and this is not a blocker, but will be re-examined as necessary later on. |
CaerusKaru
force-pushed
the
universal
branch
7 times, most recently
from
1d5260b to
1dbf11c
Compare
* Add virtual stylesheet to store server styles, which applies default styles when breakpoint overrides are not present * Intercept all style calls and reroute them to the virtual stylesheet while not in the browser * Add a new type of MediaQueryList similar to the MockMediaQueryList for the server that allows for manual activation/deactivation of breakpoints * Update deps to Angular v5.2.x and TypeScript v2.6.x
|
Succeeded by PR #567 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a WIP and still needs design review. Blocked by PR #553 since that introduces PLATFORM_ID on all elements
Design Doc: https://docs.google.com/document/d/1fg04ihw42dJJHGd6fugdiBe39iJot8aErhiE7CjwfmQ/edit#