This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
refactor(lib): upgrade to Angular v6 and Material v6 betas #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CaerusKaru
commented
Mar 7, 2018
•
CaerusKaru
commented
- Move to tree-shakeable providers where appropriate
- Deprecate unneeded providers
- Update tsconfig to workaround ngc attempts to generate metadata for rxjs Subscription in 6.0.0 angular#22210
CaerusKaru
force-pushed
the
adam/ng6
branch
7 times, most recently
from
c216413 to
f83458d
Compare
* Move to tree-shakeable providers where appropriate * Deprecate unneeded providers * Update tsconfig to workaround angular/angular#22210
| @@ -66,6 +66,7 @@ System.config({ | |||
| '@angular/cdk/scrolling': 'node:@angular/cdk/bundles/cdk-scrolling.umd.js', | |||
| '@angular/cdk/stepper': 'node:@angular/cdk/bundles/cdk-stepper.umd.js', | |||
| '@angular/cdk/table': 'node:@angular/cdk/bundles/cdk-table.umd.js', | |||
| '@angular/cdk/tree': 'node:@angular/cdk/bundles/cdk-tree.umd.js', | |||
There was a problem hiding this comment.
Why are we including the tree ? It is not used in our demos ?
Then again neither is table ;-)
There was a problem hiding this comment.
It's required for testing, otherwise Karma will try looking for it and then complain
|
Currently waiting for angular/angular#22655 |
|
Superseded by #681 to allow for separating out the tree-shakeable providers PR for later |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.