Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fxLayoutAlign): Do not apply cross-axis strech styles when not ne… #877

Merged
merged 2 commits into from
Nov 5, 2018
Merged

fix(fxLayoutAlign): Do not apply cross-axis strech styles when not ne… #877

merged 2 commits into from
Nov 5, 2018

Conversation

danmana
Copy link
Contributor

@danmana danmana commented Nov 2, 2018

…eded. Closes #876

Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru
Copy link
Member

Once this passes CI, we can get this merged. Great work!

@CaerusKaru CaerusKaru added the pr: lgtm This PR has been approved by the reviewer label Nov 2, 2018
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.20 milestone Nov 2, 2018
@CaerusKaru
Copy link
Member

Just fix the linting errors and this should be good to go 👍

@CaerusKaru CaerusKaru added pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit and removed pr: needs cleanup/tests labels Nov 5, 2018
@CaerusKaru CaerusKaru merged commit 3cd5bc1 into angular:master Nov 5, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
@danmana danmana deleted the cross-axis-stretch branch October 2, 2019 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fxLayoutAlign sets wrong max-width when used with fxLayout
3 participants