-
Notifications
You must be signed in to change notification settings - Fork 772
fix(core): clear recent styles after responsive deactivation #926
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Closed in favor of #927. Like musical chairs but with PRs |
@@ -47,8 +53,10 @@ export class MediaMarshaller { | |||
|
|||
constructor(protected matchMedia: MatchMedia, | |||
protected breakpoints: BreakPointRegistry) { | |||
this.matchMedia.observe().subscribe(this.activate.bind(this)); | |||
this.registerBreakpoints(); | |||
this.registerBreakpoints(); // register first! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
register first!
This was the entire point of #923
@@ -15,9 +15,14 @@ import {buildLayoutCSS} from '../../utils/layout-validator'; | |||
|
|||
export abstract class BaseDirective2 implements OnChanges, OnDestroy { | |||
|
|||
private destroySubject: Subject<void> = new Subject(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that we wouldn't do this because it adds complexity with very little benefit
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #697
Fixes #296