Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toc): add toc to api page #291

Merged
merged 3 commits into from
Oct 30, 2017
Merged

feat(toc): add toc to api page #291

merged 3 commits into from
Oct 30, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 16, 2017

This PR:

  • Adds Table of Contents to the API page
  • Cleans up table styles on dark themes
  • Cleans up CSS positioning on headers
  • Adds border accents to h3s in the API page
  • Misc font / line height normalization
  • Increases TOC width size
  • Adds ellipsis to TOC content if one word overflowing
  • Removes unneeded element creation during content bootstrap

It requires angular/components#7827 in order to function.

img


.docs-api-h3 {
border-bottom: 1px solid rgba(mat-color($foreground, secondary-text), 0.15);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?

1px solid mat-color($foreground, divider);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a little more in line with intention


.docs-api-h3 {
border-bottom: 1px solid rgba(mat-color($foreground, secondary-text), 0.15);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a little more in line with intention

position: relative;
a {
text-decoration: none;
margin-left: -30px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the comment?

@amcdnl
Copy link
Contributor Author

amcdnl commented Oct 30, 2017

Ready for another review.

@jelbourn
Copy link
Member

@amcdnl just needs rebase

@jelbourn jelbourn merged commit a742dc0 into angular:master Oct 30, 2017
@amcdnl amcdnl deleted the api-toc branch October 30, 2017 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants