Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

menu-bar: does not support dark mode themes #11238

Closed
Splaktar opened this issue Apr 16, 2018 · 1 comment · Fixed by #11258
Closed

menu-bar: does not support dark mode themes #11238

Splaktar opened this issue Apr 16, 2018 · 1 comment · Fixed by #11258
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed type: bug ui: theme
Milestone
1.1.10

Comments

@Splaktar
Copy link
Member

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Dark mode themes work on all components.

What is the current behavior?

Dark mode themes work on most components, but not menu-bar. This is related to the same issue (#11199) affecting menus.

What is the use-case or motivation for changing an existing behavior?

Consistent support for dark mode across components.

Which versions of AngularJS, Material, OS, and browsers are affected?

AngularJS 1.6.9
AngularJS Material 1.1.8
All browsers

Is there anything else we should know? Stack Traces, Screenshots, etc.

I can't find any dark mode examples on https://material.io/guidelines/components/menus.html#menus-specs, but I think that https://material.angular.io/components/menu/overview#nested-menu can be used as a guide.

Currently with the fixes from #11230:
screen shot 2018-04-16 at 6 28 08 pm

Angular Material:
screen shot 2018-04-16 at 6 26 09 pm
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 16, 2018
@Splaktar Splaktar mentioned this issue Apr 16, 2018
Merged
3 tasks
@Splaktar
Copy link
Member Author

Here's another more complete screenshot in dark mode since md-menu-bar also affects the md-toolbar theming:
screen shot 2018-04-16 at 7 33 33 pm

@Splaktar Splaktar modified the milestones: 1.1.9, 1.1.10 Apr 19, 2018
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 25, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
6a64cc8 
Closes angular#11238
@rudzikdawid rudzikdawid mentioned this issue Apr 25, 2018
Merged
3 tasks
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 25, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
359b917 
Closes angular#11238
@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed needs: Pull Request labels Apr 26, 2018
@Splaktar Splaktar self-assigned this Apr 26, 2018
@Splaktar Splaktar added the P4: minor Minor issues. May not be fixed without community contributions. label Apr 26, 2018
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 26, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
4396a2a 
Closes angular#11238
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 26, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
b389826 
Closes angular#11238
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 26, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
5ab683d 
Closes angular#11238
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 26, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
7aa9e2e 
Closes angular#11238
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 28, 2018
@rudzikdawid
fix(menuBar): md-menu-bar panel theme supports dark mode
6c74fef 
Closes angular#11238
tinayuangao pushed a commit that referenced this issue May 16, 2018
@rudzikdawid @tinayuangao
fix(menuBar): md-menu-bar panel theme supports dark mode (#11258)
3a21b89 
Closes #11238
Splaktar pushed a commit that referenced this issue Jul 31, 2018
@rudzikdawid @Splaktar
fix(menuBar): md-menu-bar panel theme supports dark mode (#11258)
13d2f51 
Closes #11238
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed type: bug ui: theme
Projects
None yet
Milestone
1.1.10
Development

Successfully merging a pull request may close this issue.

fix(menuBar): md-menu-bar panel theme supports dark mode rudzikdawid/material
1 participant
@Splaktar