Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(icon): providing empty alt or aria-label attributes do not hide them from a11y #12019

Merged
merged 1 commit into from
Sep 22, 2020
Merged

fix(icon): providing empty alt or aria-label attributes do not hide them from a11y #12019

merged 1 commit into from
Sep 22, 2020

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • providing empty alt or aria-label attributes do not hide them from a11y as documented

Issue Number:
Fixes #10721

What is the new behavior?

  • change behavior around how aria-label and aria-hidden is applied
    to match documentation
  • clarify documentation around alt and aria-label behavior
  • fix/improve Closure types
  • remove unused variable and out of date comments
  • replace blacklist with block-list in comments

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar
fix(icon): providing empty alt or aria-label attributes do not hide t…
b685734 
…hem from a11y

- change behavior around how `aria-label` and `aria-hidden` is applied
  to match documentation
- clarify documentation around `alt` and `aria-label` behavior
- fix/improve Closure types
- remove unused variable and out of date comments
- replace blacklist with block-list in comments

Fixes #10721
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 21, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 21, 2020
@Splaktar Splaktar self-assigned this Sep 21, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility type: bug type: docs g3: reported The issue was reported by an internal or external product team. g3: sync P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review labels Sep 21, 2020
annieyw
annieyw approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@annieyw annieyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 22, 2020
@Splaktar Splaktar merged commit 37f1535 into master Sep 22, 2020
@Splaktar Splaktar deleted the icon-a11y-refinements branch September 22, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annieyw annieyw annieyw approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@Splaktar Splaktar

Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug type: docs
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

icon: Providing empty alt or aria-label attributes do not fully hide icon from assistive tech
4 participants
@Splaktar @annieyw @wagnermaciel @googlebot