Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(fab-speed-dial): action items are in tab order when closed #12067

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • action item buttons in a closed md-fab-speed-dial are part of the tab order
  • this can also cause tooltips to appear (if the buttons have tooltips) that aren't connected to anything

Fixes #10101

What is the new behavior?

  • apply tabindex="-1" to all md-buttons in the md-fab-actions

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- apply `tabindex="-1"` to all `md-button`s in the `md-fab-actions`

Fixes #10101
@Splaktar Splaktar self-assigned this Dec 17, 2020
@google-cla google-cla bot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 17, 2020
@Splaktar Splaktar added this to the 1.2.2 milestone Dec 17, 2020
@Splaktar Splaktar added a11y This issue is related to accessibility P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review labels Dec 17, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Dec 17, 2020
@Splaktar Splaktar merged commit da86e62 into master Dec 17, 2020
@Splaktar Splaktar deleted the fab-speed-dial-actions-in-tab-order-when-closed branch December 17, 2020 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fab-speed-dial: elements inside the toolbar are tabbable when closed
2 participants