fix(checkbox, input, radio, slide-toggle): implement setDisabledState from ControlValueAccessor #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Could you add a unit test for each component that sets |
crisbeto
force-pushed
the
1171/accessor-disabled-state
branch
from
8ee8c87
to
bfc9ff5
Compare
|
Added unit tests @jelbourn. |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto can you rebase this PR? |
… from ControlValueAccessor Implements the `setDisabledState` method from the `ControlValueAccessor` interface in all of the input-related components, in order to support disabling via reactive forms. Note that the `select` component is missing the implementation, however there's a pending PR for it already (angular#1667). Fixes angular#1171.
crisbeto
force-pushed
the
1171/accessor-disabled-state
branch
from
bfc9ff5
to
9ed475b
Compare
|
Rebased @jelbourn. For some reason the entire |
|
@crisbeto Yeah that's because we changed the Line endings on the whole file. |
|
so how it fix? npm from master? thanks. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
setDisabledStatemethod from theControlValueAccessorinterface in all of the input-related components, in order to support disabling via reactive forms. Note that theselectcomponent is missing the implementation, however there's a pending PR for it already (#1667).Fixes #1171.