Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<md-input> placeholders are not working on the pink-bluegrey theme. #2106

Closed
alxhub opened this issue Dec 8, 2016 · 5 comments · Fixed by #2170
Closed

<md-input> placeholders are not working on the pink-bluegrey theme. #2106

alxhub opened this issue Dec 8, 2016 · 5 comments · Fixed by #2170
Assignees
@crisbeto

Comments

@alxhub
Copy link
Member

alxhub commented Dec 8, 2016 •
edited
Loading

Bug, feature request, or proposal:

Bug report.

What is the expected behavior?

Placeholders show up on <md-input> when using the pink-bluegrey theme.

What is the current behavior?

Placeholder text is white until the <md-input> is focused.

What are the steps to reproduce?

http://plnkr.co/edit/qjcghUoBEs0GMING1eS9?p=preview

Which versions of Angular, Material, OS, browsers are affected?

Alpha 10, Chrome 54
@crisbeto
Copy link
Member

crisbeto commented Dec 8, 2016

This due to it being a dark theme, but we don't actually apply the theme background to the body, we only have it on the md-sidenav-layout (which we use in the demo app). @jelbourn should I add the theme background to the body?

@crisbeto crisbeto self-assigned this Dec 8, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 8, 2016

@crisbeto Nope. We shouldn't change the styles of any elements not owned by a component. This should probably just be something that goes into the theming guide.

@crisbeto
Copy link
Member

crisbeto commented Dec 8, 2016 •
edited
Loading

Wouldn't this be a pretty common use case? I'd imagine that not everybody will use md-sidenav-layout as their main wrapper element.

@jelbourn
Copy link
Member

jelbourn commented Dec 8, 2016

Potentially, but I want to stick to that policy for now and try to address this with documentation.

crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 11, 2016
@crisbeto
feat(theming): provide a content wrapper attribute
1eadcca 
Adds the `[md-content-wrapper]` attribute which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-layout` and it's not something that necessarily everybody uses. It's using an attribute selector, instead of a class, in case we want to add some extra functionality to it later on.

Fixes angular#1938.
Fixes angular#2106.
@crisbeto crisbeto mentioned this issue Dec 11, 2016
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 20, 2016
@crisbeto
feat(theming): provide a content wrapper attribute
5f0362b 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 30, 2016
@crisbeto
feat(theming): provide a content wrapper attribute
ec255d5 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 12, 2017
@crisbeto
feat(theming): provide a content wrapper attribute
75e9f18 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
mmalerba pushed a commit that referenced this issue Jan 18, 2017
@crisbeto @mmalerba
feat(theming): provide a content wrapper attribute (#2170)
4bf4b87 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes #1938.
Fixes #2106.
kara pushed a commit to kara/material2 that referenced this issue Jan 20, 2017
@crisbeto @kara
feat(theming): provide a content wrapper attribute (angular#2170)
4329379 
Adds the `md-app-background` class which users can apply to their wrapper element, in order to provide the theme background. This is necessary, because the only element that does this at the moment is `md-sidenav-container` and it's not something that necessarily everybody uses.

Fixes angular#1938.
Fixes angular#2106.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theming): provide a content wrapper attribute crisbeto/material2
3 participants
@jelbourn @alxhub @crisbeto