fix(slider): make min value style match mocks #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 13, 2017
| @@ -249,12 +256,27 @@ export class MdSlider implements ControlValueAccessor { | |||
| return (this.direction == 'rtl' && !this.vertical) ? !this.invertAxis : this.invertAxis; | |||
| } | |||
|
|
|||
| /** Whether the slider is at its minimum value. */ | |||
| get _isAtMinValue() { | |||
| return DISABLED_THUMB_GAP; | ||
| } | ||
| if (this._isAtMinValue && !this.thumbLabel) { | ||
| if (this._isActive) { |
There was a problem hiding this comment.
Could replace this inner-most if-else with a ternary
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
* make slider disabled state match mocks * added test * fix lint * min value style * thumb label min value style * fix lint & add tests * fix lint * addressed comments
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocks: https://material.io/guidelines/components/sliders.html#sliders-continuous-slider