fix(slider, drawer): unsubscribe from directionaly change subject #6907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
If a slider component will be destroyed, the `ngOnDestroy` hook calls `_directionality.change.unsubscribe()`, which means that the `unsubscribe` method is called on the `EventEmitter` instead of the actual `Subscription`. This causes the `EventEmitter` to be kind of "completed", which then means that there will be errors if `emit()` is called again (https://github.com/ReactiveX/rxjs/blob/master/src/Subject.ts#L96). Also fixes that the drawer never unsubscribes from the `_dir.change` `EventEmitter`. This means that even if the component is destroyed, whenever the directionality changes, the drawer calls `validateDrawers()`. Fixes angular#6892. Fixes angular#6903.
devversion
force-pushed
the
fix/slider-drawer-dir-unsubscribe
branch
from
424f4b3
to
a15a9fa
Compare
mmalerba
approved these changes
Sep 7, 2017
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a slider component will be destroyed, the
ngOnDestroyhook calls_directionality.change.unsubscribe(), which means that theunsubscribemethod is called on theEventEmitterinstead of the actualSubscription. This causes theEventEmitterto be kind of "completed", which then means that there will be errors ifemit()is called again (https://github.com/ReactiveX/rxjs/blob/master/src/Subject.ts#L96).Also fixes that the drawer never unsubscribes from the
_dir.changeEventEmitter. This means that even if the component is destroyed, whenever the directionality changes, the drawer callsvalidateDrawers().Fixes #6892. Fixes #6903.