Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled text colors do not match for mat-select and mat-input #7793

Closed
dixy opened this issue Oct 14, 2017 · 1 comment · Fixed by #7794
Closed

Disabled text colors do not match for mat-select and mat-input #7793

dixy opened this issue Oct 14, 2017 · 1 comment · Fixed by #7794
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@dixy
Copy link

dixy commented Oct 14, 2017

Bug, feature request, or proposal:

Disabled text colors do not match for mat-select and mat-input components.

What is the expected behavior?

Same disabled colors.

What is the current behavior?

Colors are different.

What are the steps to reproduce?

Put mat-select and mat-input together in a disabled state:
http://plnkr.co/edit/LECvY5QY3zOuwtr4YEI0?p=preview

What is the use-case or motivation for changing an existing behavior?

Difference visible when mat-select and mat-input are used together in a form.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.4.4 and material 2.0.0-beta.12.
@crisbeto crisbeto self-assigned this Oct 14, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 14, 2017
@crisbeto
fix(select,input): inconsistent disabled text color
40a9101 
* Fixes the select and input having different disabled text colors since the color isn't based on a palette. Adds a mixin to ensure that they can't get out of sync in the future.
* Fixes the input having the wrong disabled text color (0.38 alpha for light themes and 0.5 for dark ones). It seems like the colors that were used before were in reference to the underline, not the text (see https://material.io/guidelines/components/text-fields.html#text-fields-states).

Fixes angular#7793.
@crisbeto crisbeto mentioned this issue Oct 14, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 14, 2017
@crisbeto
fix(select,input): inconsistent disabled text color
ba7be78 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes angular#7793.
josephperrott pushed a commit that referenced this issue Nov 10, 2017
@crisbeto @josephperrott
fix(select,input): inconsistent disabled text color
5c36f6b 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes #7793.
jelbourn pushed a commit that referenced this issue Nov 19, 2017
@crisbeto @jelbourn
fix(select,input): inconsistent disabled text color
b72c4bc 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes #7793.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 19, 2017
@crisbeto
fix(select,input): inconsistent disabled text color
fffb647 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes angular#7793.
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 20, 2017
@crisbeto
fix(select,input): inconsistent disabled text color
eda9125 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes angular#7793.
@crisbeto crisbeto added the P4 A relatively minor issue that is not relevant to core functions label Nov 28, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 1, 2017
@crisbeto
fix(select,input): inconsistent disabled text color
1165d67 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes angular#7793.
mmalerba pushed a commit that referenced this issue Dec 8, 2017
@crisbeto @mmalerba
fix(select,input): inconsistent disabled text color (#7794)
f31be6f 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes #7793.
mmalerba pushed a commit that referenced this issue Dec 8, 2017
@crisbeto @mmalerba
fix(select,input): inconsistent disabled text color (#7794)
4d47750 
Fixes the select and input having different disabled text colors and not taking colors from the palettes.

Fixes #7793.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select,input): inconsistent disabled text color crisbeto/material2
2 participants
@dixy @crisbeto