Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Closed on browser back button #8983

Closed
sijithc40 opened this issue Dec 14, 2017 · 1 comment · Fixed by #9024
Closed

[Dialog] Closed on browser back button #8983

sijithc40 opened this issue Dec 14, 2017 · 1 comment · Fixed by #9024
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@sijithc40
Copy link

Bug, feature request, or proposal:

Dialog box is getting close while click on the browser back button, Can we avoid this?

What is the expected behavior?

Popup should not be close while clicking on the browser backbutton

What is the current behavior?

I want to do some functionality in the elements inside the popup while clicking on the browser back button. Now the popup is getting close.

What are the steps to reproduce?

Providing a StackBlitz/Plunker (or similar) is the best way to get the team to see your issue.

Plunker starter (using on @master): https://goo.gl/uDmqyY

StackBlitz starter (using latest npm release): https://goo.gl/wwnhMV

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?
@andrewseguin andrewseguin changed the title Dialog box is getting close while click on the browser backbutton, Can we avoid this? [Dialog] Closed on browser back button Dec 15, 2017
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label Dec 15, 2017
@jelbourn jelbourn removed their assignment Dec 15, 2017
@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed P4 A relatively minor issue that is not relevant to core functions labels Dec 15, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 17, 2017
@crisbeto
feat(dialog): allow for closing on navigation to be disabled
c683407 
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history.

Fixes angular#8983.
This was referenced Dec 17, 2017
Merged
Closed
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2017
@crisbeto
feat(dialog): allow for closing on navigation to be disabled
d917bb4 
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history.

Fixes angular#8983.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 5, 2018
@crisbeto
feat(dialog): allow for closing on navigation to be disabled
4e08418 
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history.

Fixes angular#8983.
jelbourn pushed a commit that referenced this issue Jan 8, 2018
@crisbeto @jelbourn
feat(dialog): allow for closing on navigation to be disabled (#9024)
c349c58 
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history.

Fixes #8983.
tinayuangao pushed a commit that referenced this issue Jan 10, 2018
@crisbeto @tinayuangao
feat(dialog): allow for closing on navigation to be disabled (#9024)
f03e950 
Allows consumers to opt out of the functionality that closes all of the open dialogs when going backwards/forwards in history.

Fixes #8983.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dialog): allow for closing on navigation to be disabled crisbeto/material2
4 participants
@sijithc40 @jelbourn @crisbeto @andrewseguin