This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature(launcher): aggregate failures at the end
- Loading branch information
Showing
1 changed file
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e1cfe5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. This was required. Although the reportSummary() would not be called if their are failed test cases, as it is called in the else clause (line # 172). This way the "log_('overall: ' ....." is not called when tests are failing.
4e1cfe5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up. The difficult part about this is that the process exits with non-zero code both when spec(s) fail and when the code throws an error.
In the first case, we want to report a summary, whereas in the second place we don't (because no spec will fail, resulting in the reporter erroneously thinking that the test suite passed).
It does appear that the first case exits with code 1 while the second case exits with code 8 though. I hope that will always the case, but if not, we might need to adjust this in the future. Here's the PR to fix this: #946.