Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Enhance browser.ready #3900

Closed
sjelin opened this issue Dec 30, 2016 · 0 comments · Fixed by Jakub41/Flights-Scraper-CPH-Kastrup#46
Closed

Enhance browser.ready #3900

sjelin opened this issue Dec 30, 2016 · 0 comments · Fixed by Jakub41/Flights-Scraper-CPH-Kastrup#46
Labels
difficulty: easy hotlist: polish status: pr pending type: enhancement

Comments

@sjelin
Copy link
Contributor

sjelin commented Dec 30, 2016

In a world without the WebDriver Control Flow, we're going to need browser.ready to be better:

  • Initialize to driver.getSession(), since that will wait for the browser session to start
  • Update with the result of the getCapabilities() call call in the ProtractorBrowser constructor.
  • Update with the setScriptTimeout() call in runner.createBrowser, instead of overwriting
  • Update with the browser_.driver.getCurrentUrl() call in forkNewDriverInstance, and also return the result of newBrowser.get(url) in the subsequent then block
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser.ready): make browser.ready wait for all async setup work
1525705 
Closes angular#3900
@sjelin sjelin mentioned this issue Jan 26, 2017
Merged
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser.ready): make browser.ready wait for all async setup work
c2dd15c 
Closes angular#3900
sjelin added a commit to sjelin/protractor that referenced this issue Jan 26, 2017
@sjelin
feat(browser.ready): make browser.ready wait for all async setup work
bb5b0ac 
Closes angular#3900
sjelin added a commit that referenced this issue Jan 26, 2017
@sjelin
feat(browser.ready): make browser.ready wait for all async setup wo…
f11fece 
…rk (#4015)

Closes #3900
sjelin added a commit that referenced this issue Jan 26, 2017
@sjelin
feat(browser.ready): make browser.ready wait for all async setup wo…
dda9df4 
…rk (#4015)

Closes #3900
@sjelin sjelin closed this as completed in 7cb9739 Jan 27, 2017
igniteram pushed a commit to igniteram/protractor that referenced this issue Feb 21, 2017
@sjelin @igniteram
feat(browser.ready): make browser.ready wait for all async setup wo…
52e7e89 
…rk (angular#4015)

Closes angular#3900
@renovate renovate bot mentioned this issue May 29, 2021
Open
1 task
@renovate renovate bot mentioned this issue Jul 22, 2021
Merged
1 task
bodyduardU pushed a commit to bodyduardU/protractor that referenced this issue Dec 5, 2022
@sjelin
feat(browser.ready): make browser.ready wait for all async setup wo…
bc0508c 
…rk (#4015)

Closes angular/protractor#3900
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
difficulty: easy hotlist: polish status: pr pending type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update dependency protractor to v7 Jakub41/Flights-Scraper-CPH-Kastrup
1 participant
@sjelin