This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
chore(scripts): clean up package scripts #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cnishina
commented
Dec 5, 2016
cnishina
commented
- npm start - installs dependencies and starts the testapp
- npm run website - installs dependencies and starts the website
- cleanup testapp package scripts that are not used
- npm run format - shortcut for 'gulp format' for contributors that failed format check test
sjelin
suggested changes
Dec 5, 2016
| "tsc": "tsc", | ||
| "tsc:w": "tsc -w", | ||
| "lite": "lite-server" | ||
| "install_testapp": "npm install && npm run tsc", |
There was a problem hiding this comment.
This should probably be postinstall. Obviously we're installing the testapp, since we're in that folder. And postinstall isn't a problem since we never publish the testapp.
There was a problem hiding this comment.
Yup, postinstall would be better. Changed.
| "lite": "lite-server" | ||
| "install_testapp": "npm install && npm run tsc", | ||
| "start": "npm run install_testapp && node scripts/web-server.js", | ||
| "start_detach": "node scripts/web-server.js &", |
There was a problem hiding this comment.
it's weird that start does an install but start_detach doesn't.
There was a problem hiding this comment.
Also, what is the point of this command? Presumably people could do npm start & on their own?
There was a problem hiding this comment.
Removing install_testapp from start in favor of npm install. Removing start_detach since its only used in Travis.
cnishina
force-pushed
the
cleanup_package
branch
3 times, most recently
from
47bd071
to
cec1541
Compare
- npm start - installs dependencies and starts the testapp - npm run website - installs dependencies and starts the website - cleanup testapp package scripts that are not used - npm run format - shortcut for 'gulp format' for contributors that failed format check test
cnishina
force-pushed
the
cleanup_package
branch
from
cec1541
to
6fd92b3
Compare
sjelin
approved these changes
Dec 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.