chore(cli): **breaking change** throw errors on unknown flags

[cnishina]

clsoes #3216

[cnishina]

Test?
Fix commit message.

[sjelin]

Yes, tests please! 😛

[sjelin]

if you use an object instead of an array of Option, you can really simplify the code at the end

[sjelin]

Replace innermost loop with found = found || (optimistOptions[optimistKey][key] !== undefined)

[sjelin]

More minor changes 😄

I like the test though!

[sjelin]

Please use Array.prototype.filter instead of rolling your own version

[sjelin]

I'd rather you just initialized found to key !== '$0', since this check is pretty fast.

[sjelin]

noooo..... Ok, I can see where the miscommunication happened. Here's what I was trying to say:

let unknownKeys = Object.keys(argv).slice(2).filter((key) => {
  let found = element !== '$0';
  for (let optimistKey of Object.keys(optimistOptions)) {
    found = found || (optimistOptions[optimistKey][currentValue] !== undefined);
  }
  return found
});

[sjelin]

LGTM once the tests pass. Don't forget to make an issue as well

[sjelin]

(I'm not gonna make you do anymore with this, but it just occurred to me that Array.prototype.some is designed exactly for this situation:

let hasUnknownKeys = Object.keys(argv).some((element: string) => {
  return element !== '$0' && element !== '_' && allowedNames.indexOf(element) === -1;
});

if (hasUnknownKeys) {
  throw new Error('Found extra flags: ' + unknownKeys.join(', '));
}

It's so beautiful)

[cnishina]

So beautiful...and.....merging.