Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Fix for error "Can't return an ElementFinder from an async function" in TS 3/4 #5468

Closed
wants to merge 1 commit into from

Conversation

awaisraad
Copy link

Fixes ElementFinder so that protractor can be used with Typescript v3, v4.

Typescript fails to compile when ElementFinder is returned from an async function. This is because of optional property "then" present on ElementFinder. Previously this property was removed in #1926 but re-added back in #3835 as an optional. So I suggest that this property be removed again so that protractor can be used with Typescript version 3 and onward.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@awaisraad
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@awaisraad awaisraad closed this Sep 6, 2020
@debajyoti3061
Copy link

@awaisraad Thanks for fixing this.Which version of protractor has this fix?

@lyubomiraleksiev
Copy link

@debajyoti3061 this pr has not been approved, hence has not been merged into master.

@awaisraad
Copy link
Author

@debajyoti3061 I have removed my PR because the email was different in commits and the one with which I signed SLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants