Mangle type names when they conflict with values #1077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - augmented browser global - externs - an enum (which is also a type/value).
Given input where a type and value conflict, like
interface X { ... }
const X = 3;
this makes us emit the interface as
function X$$TSType() { }
etc.
This is not used anywhere yet; it purely adds the additional emit.
An upcoming change makes tsickle need to know whether a given module was processed by tsickle or not. This change makes tsickle emit a constant string at the head of each d.ts file that it can look for. For example, when tsickle compiles library a.ts, it emits a.d.ts. Then when compiling b.ts that imports from a, it still knows (from the tag in a.d.ts) that the JS emitted for a has been processed. This change adds the header but does not make use of it.
When there's a type/value conflict, we emit a mangled name for the type. This change makes tsickle emit references to those mangled names when the types are used. Importantly, we need to be careful to only use mangled names in the case where we're certain that the JS underneath was emitted via tsickle already. To do so we check the header that we added to the d.ts emit.
|
I'm gonna sit on this. I think we will need to do something like it eventually, but I fixed the larger clutz issue separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits changes our emit for code like
Previously, we'd just quietly drop the
Xbecause of the conflict.With this change, we instead emit the type with a mangled name:
Then when some code wants to use that type, it needs to know whether that type has a mangled JS name. To do so I add a header to any tsickle-emitted d.ts. This actually let me remove a hack related to standard library types too.