Add support for TypeScript 3.8 #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrdelaney
force-pushed
the
ts38
branch
2 times, most recently
from
55cc2db
to
7d29c24
Compare
mprobst
reviewed
Feb 27, 2020
mprobst
approved these changes
Feb 27, 2020
|
Nice! |
This upgrades the version of TypeScript Tsickle uses as a
`devDependency` and a `peerDependency`.
Support for Private Fields
--------------------------
Tsickle mostly ignores private fields, however it no longer warns when
not generating externs for them. Externs are not generated because the
fields no not exist on the class when downleveled.
Support for `export * as ns` Syntax
-----------------------------------
Tsickle compiles:
```ts
export * as ns from './namespace';
```
to
```ts
var tsickle_module_1_ = goog.require('project.namespace');
exports.ns = tsickle_module_1_;
```
New `tslib` Functions
---------------------
Private fields require two new functions in `tslib`:
`__classPrivateFieldGet` and `__classPrivateFieldSet`. Both of these
were added to Tsickle's version of `tslib.js` along with Closure type
annotations.
Other Changes
-------------
* The `import_export_typedef_conflict` test was removed because that
code is no longer valid in TypeScript 3.8, and produces a compile
error.
* `tslib@1.11.0` was added as a `devDependency`. Before it was being
pulled in as a transitive dependency, but the packages pulling it in
depend on `1.10`. To upgrade to TypeScript 3.8 Tsickle needs the latest
version of `tslib`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the version of TypeScript Tsickle uses as a
devDependencyand apeerDependency, which in turn upgrades thetslibversion.Support for Private Fields
Tsickle mostly ignores private fields, however it no longer warns when not generating externs for them. Externs are not generated because the fields no not exist on the class when downleveled.
Support for
export * as nsSyntaxTsickle compiles:
to
New
tslibFunctionsPrivate fields require two new functions in
tslib:__classPrivateFieldGetand__classPrivateFieldSet. Both of these were added to Tsickle's version oftslib.jsalong with Closure type annotations.Other Changes
import_export_typedef_conflicttest was removed because that code is no longer valid in TypeScript 3.8, and produces a compile error.tslib@1.11.0was added as adevDependency. Before it was being pulled in as a transitive dependency, but the packages pulling it in depend on1.10. To upgrade to TypeScript 3.8 Tsickle needs the latest version oftslib.