This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
feat(hapi): upgrade to Hapi v17 #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaerusKaru
added
action: review
comp: hapi-engine
target: minor
Toxicable
suggested changes
Jun 9, 2018
| }).then(html => reply(html)) | ||
| .then(err => reply(boom.wrap(err))); | ||
| } | ||
| handler: (req: Request) => ngHapiEngine({req, bootstrap: ServerAppModule}) |
There was a problem hiding this comment.
does it have to instantiate the whole engine per request? feels like a bit of overhead
There was a problem hiding this comment.
Yeah, at least for now, because the argument for ngHapiEngine is RenderOptions, which has a mandatory req. And it's not instantiation. Remember: the engine is just a function wrapper around renderPlatformServer. It still does all the caching because that's handled in a constant external to the wrapper.
Toxicable
approved these changes
Jun 10, 2018
|
Just needs a rebase |
CaerusKaru
added
PR state: LGTM
action: merge
CaerusKaru
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993