Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

refactor: remove deprecated engines #2567

Merged
merged 2 commits into from
Mar 7, 2022
Merged

refactor: remove deprecated engines #2567

merged 2 commits into from
Mar 7, 2022

Conversation

alan-agius4
Copy link
Collaborator

BREAKING CHANGE:

Deprecated @nguniversal/aspnetcore-engine, @nguniversal/hapi-engine and @nguniversal/socket-engine has been removed in favor of @nguniversal/common.

Closes #1232, closes #750 and closes angular/angular-cli#25726

@alan-agius4 alan-agius4 requested a review from CaerusKaru March 7, 2022 07:59
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 7, 2022
@alan-agius4
refactor: remove deprecated engines
f575288 
BREAKING CHANGE:

Deprecated `@nguniversal/aspnetcore-engine`, `@nguniversal/hapi-engine` and `@nguniversal/socket-engine` has been removed in favor of `@nguniversal/common`.

Closes #1232, closes #750 and closes #1454
@alan-agius4
build: update chrome driver to 99.0.4844.17
cc184f6
@hiepxanh
Copy link
Contributor

hiepxanh commented Mar 7, 2022

nice PR, looking for this to merge

@alan-agius4 alan-agius4 added the action: merge PR author is ready for this to merge label Mar 7, 2022
@alan-agius4 alan-agius4 merged commit bf2805f into angular:master Mar 7, 2022
@alan-agius4 alan-agius4 deleted the remove-deps branch March 7, 2022 13:50
@PowerKiKi PowerKiKi mentioned this pull request Mar 7, 2022
Closed
6 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2022
@angular angular unlocked this conversation Aug 29, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaerusKaru CaerusKaru CaerusKaru approved these changes

Assignees
No one assigned
Labels
action: merge PR author is ready for this to merge flag: breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
3 participants
@alan-agius4 @hiepxanh @CaerusKaru