feat(ng-aspnetcore-engine): adding initial new engine #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPRIT
approved these changes
Mar 29, 2017
vikerman
previously requested changes
Mar 29, 2017
modules/aspnetcore-engine/index.ts
Outdated
|
|
||
| return new Promise((resolve, reject) => { | ||
|
|
||
| const platform = platformDynamicServer(providers); |
There was a problem hiding this comment.
Please user platformServer only since platformDynamicServer would compile the whole app every time.
There was a problem hiding this comment.
Yeah I need to do that and update the npm name as well.
…/universal into ng-aspnetcore-engine
vikerman
approved these changes
Apr 25, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP