Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

feat(common): add CommonEngine to encapsulate rendering #996

Merged
merged 1 commit into from
May 19, 2018

Conversation

Toxicable
Copy link

@Toxicable Toxicable commented May 18, 2018

Supersedes #912

Introduces a new CommonEngine to bring together logic from other ones.
it includes

  • No breaking changes.
  • No new public apis

Will only be used internally for now

The other engines will migrate to use this at a later point

Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's remember to add docs for this later

@CaerusKaru CaerusKaru added PR state: LGTM action: merge PR author is ready for this to merge target: minor target: minor This PR is targeted for the next minor release area: common labels May 19, 2018
@CaerusKaru CaerusKaru added this to the 6.0 milestone May 19, 2018
@Toxicable Toxicable merged commit 439b306 into master May 19, 2018
@Toxicable Toxicable deleted the fabian/common2 branch May 19, 2018 19:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge PR author is ready for this to merge area: common target: minor target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants