-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language service crashes if there is an error during Typecheck block generation #1881
Comments
…ecking This commit updates the type checking step of the compilation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking This commit updates the type checking step of the compilation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881
…ecking (#49527) This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881 PR Close #49527
…ecking (#49792) This commit updates the type checking operation to catch `FatalDiagnosticError` and surface them as diagnostics rather than crashing. Fixes angular/vscode-ng-language-service#1881 PR Close #49792
Hi @atscott, I'm sorry for commenting on closed issue. But after I update my Angular Language Service to 15.2.1, Angular to 15.2.8, and the component library, Clarity Design, to the latest version that had exported previously unexported directive, the issue persist. I set
Is there anything I can provide to help trace the cause? |
…r components This commit adds similar handling to what was done in angular@ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881
…r components This commit adds similar handling to what was done in angular@ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881
…r components This commit adds similar handling to what was done in angular@ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881
…r components (#50046) This commit adds similar handling to what was done in ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881 PR Close #50046
…r components (#50046) This commit adds similar handling to what was done in ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881 PR Close #50046
…r components (angular#50046) This commit adds similar handling to what was done in angular@ed817e3. The language service calls the `getDiagnosticsForComponent` function when the file is not a typescript file. fixes angular/vscode-ng-language-service#1881 PR Close angular#50046
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Discovered from #1840 (comment)
Steps to reproduce:
(Note: also need to update the
index.ts
to export justPostComponent
andPostModule
rather than everything from the file.2. build the integration project (
yarn --cwd integration/project build
)3. Open
foo.component.html
- the language service will crash because the template type check block cannot import the non-exportedHostBindDirective
The text was updated successfully, but these errors were encountered: