Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Commit

Permalink
feat(Compiler): DirectiveNormalizer => AstDirectiveNormalizer.
Browse files Browse the repository at this point in the history
This switches the directive/template normalization process (part of the processing before passing metadata to the view compiler) to use the package:angular_ast-based template parser instead of the old one. This should resolve errors like:

"NoSuchMethod: =endSourceSpan"

... which were due to bad recovery in the old parser.

PiperOrigin-RevId: 190860110
  • Loading branch information
matanlurey committed Mar 29, 2018
1 parent d5aef2f commit 52527ce
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions angular/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@
`\u{?-??????}`. This enables support for Unicode supplementary planes, which
includes emojis!

### Internal cleanup

* Template normalization in the compiler now uses the newer template parser
based on `package:angular_ast`. There is no flag to enable the old behavior
but please reach out if you see issues in this release.

## 5.0.0-alpha+8

### New features
Expand Down
2 changes: 1 addition & 1 deletion angular_compiler/lib/src/cli/flags.dart
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class CompilerFlags {
this.ignoreNgPlaceholderForGoldens: false,
this.profileFor: Profile.none,
this.useFastBoot: true,
this.useNewTemplateNormalizer: false,
this.useNewTemplateNormalizer: true,
this.useLegacyStyleEncapsulation: false,
this.useNewPreserveWhitespace: false,
});
Expand Down

0 comments on commit 52527ce

Please sign in to comment.